-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolved faulty spinner loading after error in console #1609
Conversation
|
Although this particular bug is fixed by adding try catch block , I am not very confident in the implementation and working of this command because i tried using interactive mode and it didn't work as it should . |
Quality Gate passedIssues Measures |
@SahilDahekar can you attach some images of the error, and solution hard to understand what is happening. |
Before :The Generating models spinner does not stop even after error. In order to stop have to manually cancel the operation. After :No longer have faulty spinner and error logged to console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
/rtm |
Description
Error
is throw bygenerateModels()
func.Related issue(s)
Resolves #1607